Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Safari working with FCM now. #9891

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Get Safari working with FCM now. #9891

merged 7 commits into from
Nov 13, 2024

Conversation

burtonator
Copy link
Collaborator

Link to Issue

Closes: #9793

Description of Changes

  • adds the changes to get FCM working.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@burtonator burtonator self-assigned this Nov 13, 2024
@github-actions github-actions bot marked this pull request as draft November 13, 2024 00:44
@burtonator burtonator marked this pull request as ready for review November 13, 2024 00:46
@burtonator burtonator merged commit 6cdfc6e into master Nov 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israellund Israellund Israellund approved these changes

@mzparacha mzparacha mzparacha approved these changes

@masvelio masvelio Awaiting requested review from masvelio

Assignees

@burtonator burtonator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get web based push notifications working for safari
3 participants
@burtonator @mzparacha @Israellund