-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loads global .env in vite.config to fix vscode extension #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
previously approved these changes
Nov 13, 2024
kurtisassad
reviewed
Nov 14, 2024
kurtisassad
approved these changes
Nov 14, 2024
timolegros
reviewed
Nov 14, 2024
Yes @timolegros, I'm using this opportunity to remove unused variables and simplify bootstrapping and configuration. Next step is to work on test parallelization (future PR) |
rbennettcw
approved these changes
Nov 15, 2024
timolegros
reviewed
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9897
This is the configuration that worked for me locally and using the VSCode extension. I had to disable parallel execution for the extension to be able to run all tests at once. We should continue working on trying to parallelize all tests in the future.
Description of Changes
"How We Fixed It"
Test Plan
FIXME()
call.Deployment Plan
Other Considerations