Topic Archival

[timolegros]

Link to Issue

Closes: #9825

Description of Changes

• Switched from 'delete topic' to 'archive topic'
• Added topic unarchival

Test Plan

Deployment Plan

#9825 (comment)

For the 3 threads in the common community, someone from growth should assign them a topic and for the 2 in dhk we should reach out to them or assign a random topic:

• https://commonwealth.im/dhk/discussion/17316
• https://commonwealth.im/dhk/discussion/15350
• https://commonwealth.im/common/discussion/24689
• https://commonwealth.im/common/discussion/24656
• https://commonwealth.im/common/discussion/24699

Other Considerations

[timolegros]

@mzparacha, the backend for this PR is complete. When you hit 'delete topic' on the client, it will archive the topic and its threads (they show up in archived). What remains to do on the client:

• Update button/modal warning text to reflect archival
• Add 'unarchive' functionality -> This may not be necessary for this PR (maybe a separate ticket?)
• Verify there are no unintended side effects from loading topics anywhere else

[mzparacha]

@timolegros I did this frontend work

• Archiving/Unarchiving topics + refreshing thread cache when this happens
• Testing for side effects (didn't find any)

I did find 1 issue with unarchiving a topic -> when unarchived the threads of that topic remain archived for some reason, could you please take a look a this. Also, I couldn't verify cache updates for this case in frontend, will try it after we update the command.

[timolegros]

@mzparacha fixed the bug. For caching on the client most everything seemed to work except 1 thing: after archiving a topic the archived threads did not show up in the archived section until I refreshed. Other than that I think this is ready.

[mzparacha]

@mzparacha fixed the bug. For caching on the client most everything seemed to work except 1 thing: after archiving a topic the archived threads did not show up in the archived section until I refreshed. Other than that I think this is ready.

Tested but wasn't able to repro

Screen.Recording.2024-11-13.at.5.44.25.PM.mov

cc: @timolegros

[timolegros]

@mzparacha fixed the bug. For caching on the client most everything seemed to work except 1 thing: after archiving a topic the archived threads did not show up in the archived section until I refreshed. Other than that I think this is ready.

Tested but wasn't able to repro
Screen.Recording.2024-11-13.at.5.44.25.PM.mov

cc: @timolegros

huh ok no worries then. Can you push a fix for the lint errors and then I will put this up for review?