Auth middleware updated #9870
Merged
Auth middleware updated #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Very nice. It does make me a little nervous to refactor the entire auth system (again lol) - might be a good time to add auth-related tests for relevant entities (where missing). That said, given the scope of this PR I'm ok with merging this quickly to avoid conflicts and following up with more auth-related tests after (though in the same release).
rbennettcw
approved these changes
Nov 12, 2024
kurtisassad
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9869
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations