Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launchpad Discovery]: Token Trade From Explore Page - Buy Mode #9867

Merged
merged 38 commits into from
Nov 14, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Nov 8, 2024

Link to Issue

Closes: #8804

Description of Changes

Added ability to buy tokens from the explore page.

"How We Fixed It"

N/A

Test Plan

  1. Create a new token
  2. Visit the explore page and attempt to buy that token (ignore the pricing data - its placeholder)
  3. In the buy modal verify you correctly see the eth amount in your selected address
  4. Verify the dollar amount you enter correctly translates into eth amount
  5. Verify you are able to see receipt details correctly (tokens bought are hardcoded for now)
  6. Verify you are able to buy the token successfully
  7. Verify the modal closes after the token is bought successfully
  8. Verify you get joined to the token community if not already joined after a successful token purchase.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft November 8, 2024 14:11
timolegros added a commit that referenced this pull request Nov 11, 2024
@mzparacha
Copy link
Contributor Author

I got some weird errors (from libs/model/src/community/UpdateCommunity.command.ts) when updating the community namespace after creating a token. ATM I just commented out the code that was causing errors.

Also, libs/schemas/src/entities/token.schemas.ts was throwing weird zod type errors and failing create token call, cause of the initial_supply field, atm I added .any() to bypass that.

@kurtisassad - would appreciate your help on these 2 things.

@mzparacha mzparacha changed the title [Launchpad Discovery]: Token Trade From Explore Page [Launchpad Discovery]: Token Trade From Explore Page - Buy Mode Nov 13, 2024
@mzparacha mzparacha self-assigned this Nov 13, 2024
@mzparacha mzparacha marked this pull request as ready for review November 13, 2024 19:59
@mzparacha mzparacha merged commit 6d917f2 into master Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Token Purchase from Explore Page
5 participants