Kaleem neslit.9501.merge all oveview #9854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaleemNeslit
requested review from
masvelio,
mzparacha and
Israellund
and removed request for
masvelio and
mzparacha
… into kaleemNeslit.9501.merge_all_oveview
masvelio
reviewed
Nov 8, 2024
packages/commonwealth/client/scripts/views/components/react_quill_editor/LinkModal.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/components/react_quill_editor/react_quill_editor.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/components/react_quill_editor/toolbar.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/pages/discussions/DiscussionsPage.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/pages/discussions/DiscussionsPage.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/pages/overview/index.tsx
Outdated
Show resolved
Hide resolved
mzparacha
reviewed
Nov 8, 2024
mzparacha
reviewed
Nov 8, 2024
packages/commonwealth/client/scripts/views/pages/overview/index.tsx
Outdated
Show resolved
Hide resolved
mzparacha
reviewed
Nov 8, 2024
.../commonwealth/client/scripts/views/pages/discussions/HeaderWithFilters/HeaderWithFilters.tsx
Outdated
Show resolved
Hide resolved
mzparacha
reviewed
Nov 8, 2024
.../commonwealth/client/scripts/views/pages/discussions/HeaderWithFilters/HeaderWithFilters.tsx
Show resolved
Hide resolved
mzparacha
reviewed
Nov 8, 2024
.../commonwealth/client/scripts/views/pages/discussions/HeaderWithFilters/HeaderWithFilters.tsx
Outdated
Show resolved
Hide resolved
…iscussionsPage.tsx Co-authored-by: Marcin Maslanka <[email protected]>
… into kaleemNeslit.9501.merge_all_oveview
…com/hicommonwealth/commonwealth into kaleemNeslit.9501.merge_all_oveview
|
Hey @KaleemNeslit sorry we updated the design -> Please see this file: 
|
dillchen
requested changes
Nov 8, 2024
sure i am looking into it |
|
For visibility, we're gonna use these for icons for All / Overview: https://www.figma.com/design/dGPiswtnIfQIzSNOlB4MNC/Sticky-editor-%2B-Sidebar-%2B-Thread-UI?node-id=849-2150&t=0WhzNPyv8wyiMzgb-4 |
|
|
dillchen
approved these changes
Nov 12, 2024
mzparacha
reviewed
Nov 13, 2024
packages/commonwealth/client/scripts/views/pages/overview/index.tsx
Outdated
Show resolved
Hide resolved
mzparacha
approved these changes
Nov 13, 2024
|
@mzparacha fixed mentioned comments also showed All/Overview filter on all other sorts filters as well. |
|
@KaleemNeslit This looks good, feel free to merge today. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9501
Description of Changes
"How We Fixed It"
Test Plan
Goto and community and check the tabs to navigate btw all and overView page
-go community and then in Admin Capabilities sidebar click the Community Profile and then scroll to Default page and then select the page type as default.
Here is the video of test
Screen.Recording.2024-11-07.at.8.52.40.PM.mov