Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds delete quest command plus a few guards and tests #9809

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Adds delete quest command plus a few guards and tests #9809

merged 1 commit into from
Nov 6, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Nov 5, 2024 •
edited
Loading

Link to Issue

Closes: #9386

Description of Changes

  • Adds new command
  • Adds guards for time periods, and updates existing commands to use new guards
  • Updates lifecycle test to include deletes and new guards

"How We Fixed It"

Test Plan

  • Unit tested

Deployment Plan

Other Considerations

@Rotorsoft Rotorsoft merged commit 5d7166f into master Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@timolegros timolegros timolegros approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🟦 DeleteQuest
3 participants
@Rotorsoft @timolegros @rbennettcw