Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threads discussion page cache #9805

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Nov 5, 2024

Link to Issue

Closes: #9740

Description of Changes

Updated thread cache keys on the community discussion page to correctly cache keys for thread cache time.

"How We Fixed It"

N/A

Test Plan

  1. Open network tab
  2. Visit any community discussions page
  3. Look for the /threads?bulk=true call
  4. Visit any other page
  5. Come back to the same discussions page
  6. Verify there isn't a new call to /threads?bulk=true in the network tab
  7. Verify any updates to the threads displayed in the discussion list are reflected, when updates to the threads in that ist are done from any other page
  8. Verity that after every 3 minutes, a new call to /threads?bulk=true is made when on the community discussions page.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft November 5, 2024 14:55
@mzparacha mzparacha marked this pull request as ready for review November 5, 2024 14:59
@mzparacha mzparacha self-assigned this Nov 5, 2024
@mzparacha mzparacha merged commit 0df74cf into master Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix thread discussion page cache keys to hold cache for x time
3 participants