fix the edit thread title #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaleemNeslit
requested review from
mzparacha,
masvelio,
burtonator and
Israellund
Israellund
approved these changes
Nov 5, 2024
masvelio
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9280
@Israellund this PR also closed the #9282
Description of Changes
"How We Fixed It"
-remove the condition value={draftTitle || thread?.title} only used draftTitle
-disable the save button when title is empty
Test Plan
make sure you're an admin
-go to a thread and click the 3 dots, choose Edit
-in edit mode try to edit the modal
Screen.Recording.2024-11-05.at.7.27.08.PM.mov