Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove weighted topics feature flag #9785

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Remove weighted topics feature flag #9785

merged 2 commits into from
Nov 4, 2024

Conversation

masvelio
Copy link
Contributor

@masvelio masvelio commented Nov 4, 2024

Link to Issue

Closes: #9712

Description of Changes

  • removed feature flag
  • removed conditional code that is not used anymore

Test Plan

  • when you had FLAG_WEIGHTED_TOPICS turned on, nothing should really change

Deployment Plan

  1. we can remove FLAG_WEIGHTED_TOPICS from heroku and unleash

Other Considerations

  • n/a

@masvelio masvelio added the deployment plan (PRs only) requires manual infrastructure changes on release label Nov 4, 2024
@masvelio masvelio merged commit 5f95ae1 into master Nov 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@Israellund Israellund Israellund approved these changes

@mzparacha mzparacha mzparacha approved these changes

Assignees
No one assigned
Labels
deployment plan (PRs only) requires manual infrastructure changes on release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove weightedTopics feature flag
4 participants
@masvelio @mzparacha @Israellund @rbennettcw