Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with knock... other than the markdown issues. #9742

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

burtonator
Copy link
Collaborator

@burtonator burtonator commented Oct 31, 2024

Link to Issue

Closes: #9743

Description of Changes

  • fixe titles and bodies and memoize the knock notifications component.

"How We Fixed It"

Test Plan

Deployment Plan

Other Considerations

@burtonator burtonator marked this pull request as ready for review October 31, 2024 20:04
@burtonator burtonator changed the title DRAFT: Fixes issues with knock... other than the markdown issues. Fixes issues with knock... other than the markdown issues. Oct 31, 2024
@dillchen dillchen self-requested a review October 31, 2024 20:16
Copy link
Contributor

@ianrowan ianrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@burtonator burtonator merged commit 6e94144 into master Oct 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed missing message body and title in some messages in push notifications.
3 participants