Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ViewCounts #9733

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Clean up ViewCounts #9733

merged 6 commits into from
Nov 1, 2024

Conversation

timolegros
Copy link
Collaborator

Link to Issue

Closes: #9593

Description of Changes

  • Removed view count cache
  • Remove /viewCount route and moved view count incrementing to GetThreadsByIds output middleware

Test Plan

  • View specific threads and ensure view counts increment after refresh

Deployment Plan

Other Considerations

@timolegros timolegros marked this pull request as ready for review October 30, 2024 22:56
Rotorsoft
Rotorsoft approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@timolegros timolegros merged commit e1b0363 into master Nov 1, 2024
10 checks passed
@timolegros timolegros deleted the tim/update-view-counts branch November 1, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ViewCountCache + increment view count in GetThreadsByIds output middleware
3 participants
@timolegros @kurtisassad @Rotorsoft