Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown editor v6 #9708

Merged
merged 9 commits into from
Nov 12, 2024
Merged

markdown editor v6 #9708

merged 9 commits into from
Nov 12, 2024

Conversation

burtonator
Copy link
Collaborator

@burtonator burtonator commented Oct 28, 2024

Don't do a full QA of this PR yet. I'm still fixing a few more Safari + Mobile issues.

I'm going to start testing the integration into the site next and we can start being more picky then as some of the functionality might change.

The biggest change here is fixing Safari on iOS / iPad OS 18.1 and solving the keyboard detection issue.

Link to Issue

Closes: #9709

Description of Changes

Fixed the following issues.

  • Focus seems to be inconsistent with the keyboard use so I need to double check everything and audit it.
  • Make sure the secondary buttons focus properly. I don't them all of them are.
  • selecting the 'p' block style in Safari on iPad causes the editor to lose focus and it goes to 'body'. This doesn't happen for h1, etc.
  • paragraph selection DOES cause focus to be lost on mobile
  • test safari + ipad
  • keyboard does NOT become active on Safari + iPad
  • The padding for the button on mobile button bar on iOS seems wrong

"How We Fixed It"

Test Plan

  • none just yet.

Deployment Plan

Other Considerations

@burtonator burtonator changed the title draft: Burton/editor v6 markdown editor v6 Oct 28, 2024
@burtonator burtonator marked this pull request as ready for review October 28, 2024 23:41
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

@burtonator burtonator merged commit 6a3f31c into master Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6 of the new markdown editor.
4 participants