-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown editor v6 #9708
Merged
Merged
markdown editor v6 #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masvelio
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments
packages/commonwealth/client/scripts/views/components/MarkdownEditor/toolbars/FormatButton.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/components/MarkdownEditor/toolbars/FormatButton.scss
Outdated
Show resolved
Hide resolved
...ommonwealth/client/scripts/views/components/MarkdownEditor/useMobileKeyboardResizeHandler.ts
Outdated
Show resolved
Hide resolved
- cleanup from PR
Israellund
approved these changes
Oct 29, 2024
mzparacha
reviewed
Oct 30, 2024
...commonwealth/client/scripts/views/components/MarkdownEditor/toolbars/BlockSelectorButton.tsx
Outdated
Show resolved
Hide resolved
mzparacha
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't do a full QA of this PR yet. I'm still fixing a few more Safari + Mobile issues.
I'm going to start testing the integration into the site next and we can start being more picky then as some of the functionality might change.
The biggest change here is fixing Safari on iOS / iPad OS 18.1 and solving the keyboard detection issue.
Link to Issue
Closes: #9709
Description of Changes
Fixed the following issues.
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations