Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation of threads on For-You/Global is not showing Show More on mobile #9698

Conversation

salman-neslit
Copy link
Collaborator

Link to Issue

Closes: #9622

Description of Changes

  • Fixed the missing "Show More" functionality on mobile for threads on the For-You and Global pages.
  • Ensured that thread information truncation on mobile matches the desktop experience, with a fading effect for text and a visible "Show More" button in blue.

"How We Fixed It"

  • The max-height restriction on the .content-body class for extra small screens was removed, allowing the text to display correctly with truncation. This ensures that the fading effect is applied, and the "Show More" button appears as expected, allowing users to expand the full thread when clicked.

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@salman-neslit salman-neslit marked this pull request as ready for review October 28, 2024 21:04
@salman-neslit
Copy link
Collaborator Author

Screen.Recording.2024-10-29.at.2.12.12.AM.mov

@salman-neslit
Copy link
Collaborator Author

@Israellund, I’ve observed that the "show more" functionality appears to be managed by <MarkdownViewerUsingQuillOrNewEditor>. It doesn’t seem to rely on the actual amount of text displayed on the screen. Instead, it seems to trigger based on the number of times the enter key is pressed, rather than the length of the content. Consequently, if a large block of text is copied and pasted, the "show more" function doesn’t activate. I’m not certain if this behavior is intentional, but it may be worth reviewing.

Screen.Recording.2024-10-29.at.2.52.08.AM.mov

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quill has a lot of quirks. We are in the process of moving to the new editor so I wouldn't spend too much time on fixing minor things. Thanks for spotting it though.

… into salman/Issue#9622/trunction-of-thread-not-showwing-show-more-on-mobile
@salman-neslit salman-neslit merged commit 2995a4b into master Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncation of threads on For-You/Global is not showing Show More on mobile
3 participants