-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Canvas to v0.12.0, peer with Explorer #9650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use new libp2p api
… of @hicommonwealth/shared
raykyri
force-pushed
the
rjwebb/upgrade-canvas-to-0-11-0
branch
from
October 23, 2024 17:39
560c5df
to
b24bc22
Compare
raykyri
changed the title
Upgrade Canvas to v0.12.0
Upgrade Canvas to v0.12.0, peer with Explorer
Oct 23, 2024
raykyri
commented
Oct 23, 2024
raykyri
added
5
Few days task
3
Full day task
deployment plan
(PRs only) requires manual infrastructure changes on release
labels
Oct 23, 2024
Why? Did importing core cause issues? |
timolegros
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix lockfile
kurtisassad
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3
Full day task
5
Few days task
deployment plan
(PRs only) requires manual infrastructure changes on release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Canvas version to 0.12.0, and adds a default peering configuration pointing to https://common-explorer.canvas.xyz/, which is autodeployed from https://github.com/canvasxyz/canvas/tree/main/examples/common-explorer#common-network-explorer.
Canvas<T extends ModelSchema>
object, which is the main "app" abstraction for Canvas, but doesn't otherwise introduce any major new changes.PEER_ID
env var has not changed.app.startLibp2p
.SIWESigner
has changed slightly, if we create aSIWESigner
without asigner
config value then it generates an ethers wallet and then saves it in local storage. This does not affect how Commonwealth works because we always pass in a signer config value (which would be some kind of handle to the MetaMask/WalletConnect/etc browser extension) but it meant that some of the test fixture code had to be changed to explicitly always create a new ethers wallet.This also changes the logger inside packages/commonwealth/scripts/create-peer-id.ts to use console.log instead of the builtin logger, to avoid importing @hicommonwealth/core...
Link to Issue
Closes: #8919, #7520.
Test Plan
pnpm start
, create a comment with an account with a live session key, and it should show up on common-explorer.canvas.xyz.Deployment Plan
./create-peer-id.ts
in packages/commonwealth/scripts, and slack @raykyri with the resulting public key (printed 12D3Koo... above the private key).Other Considerations