Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot Webhook Update #9589

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Snapshot Webhook Update #9589

merged 2 commits into from
Oct 18, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Oct 18, 2024 •
edited
Loading

Link to Issue

Closes: #9406

Description of Changes

  • Check authentication header

Test Plan

Deployment Plan

  1. Set SNAPSHOT_WEBHOOK_SECRET env var in all Heroku apps

Other Considerations

@timolegros timolegros marked this pull request as ready for review October 18, 2024 08:22
@timolegros timolegros added the deployment plan (PRs only) requires manual infrastructure changes on release label Oct 18, 2024
@timolegros timolegros merged commit a813955 into master Oct 18, 2024
11 checks passed
@timolegros timolegros deleted the tim/snapshot-security branch October 18, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

Assignees
No one assigned
Labels
deployment plan (PRs only) requires manual infrastructure changes on release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot Security
3 participants
@timolegros @Rotorsoft @rbennettcw