-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode DB contents #9186
Merged
Merged
Decode DB contents #9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timolegros
requested review from
burtonator,
kurtisassad,
Rotorsoft and
rbennettcw
September 12, 2024 06:45
timolegros
added
the
deployment plan
(PRs only) requires manual infrastructure changes on release
label
Sep 12, 2024
This was referenced Sep 12, 2024
Closed
burtonator
approved these changes
Sep 12, 2024
rbennettcw
approved these changes
Sep 12, 2024
masvelio
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followed test plan, clicked around, didnt see any issues
# Conflicts: # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is not nearly as large as it seems to be. 652 lines are changes to the pnpm lockfile. Only 234 actual lines to review.
Link to Issue
Closes: #9182
Closes: #9168
Closes: #9169
Description of Changes
decodeContent
function which removes URI encoding and converts Quill Deltas to raw markdownencodeURIComponent
for thread/comment CRUD API callsTest Plan
Deployment Plan
AFTER DEPLOYMENT:
heroku run bash -a commonwealthapp
packages/commonwealth/
run:pnpm ts-exec scripts/decode-db-content.ts threads
pnpm ts-exec scripts/decode-db-content.ts thread-versions
pnpm ts-exec scripts/decode-db-content.ts comments
pnpm ts-exec scripts/decode-db-content.ts comment-versions
Other Considerations