-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added script to automate cloudflare cache purge #8736
Conversation
ca028f4
to
00a9dc9
Compare
0df13d5
to
64cf7ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine though I think the errors should propagate to a single point and result in a non-zero exit code because the runtime environment usually does utilize that info somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments. Does this release phase step work conceptually (I might be missing something)? The dynos will not have restarted yet when the release phase is running so they will still be serving the old code, won't the cache repopulate with the existing app files instead of repopulating with the new app files that are deployed after the script completes? Seems like cache clearing needs to happen after deployment not during release no?
Link to Issue
Closes: #8487
Test Plan
tsx ./purgeCloudflareCache.ts
, you should get a success response from the cloudflare api indicating that the cache has been purged.Deployment Plan
Need to add env vars CF_ZONE_ID and CF_API_KEY to heroku.