-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom domain functions to admin panel #8227
Conversation
Never mind it seems to be there already. That said, we need to somehow keep track of when growth is linking a new custom domain because Alchemy and Magic (not sure about Magic) don't have APIs to update their whitelists programmatically. |
Per my previous comment, how do we deal with Alchemy whitelisting? Since they don't have an API to update the whitelist we need to manually add domains to the whitelist. Most chain interactions from a custom domain for an EVM community will fail unless we add that community to the whitelist. This should be very clearly outlined to Growth and it does mean that Growth still needs to create a ticket when adding a Custom domain for EVM communities. |
Discussed with Tim, we will get this in first and then figure out the alchemy whitelist flow, there seems to be some docs on generating a JWT, so we can go with that approach when he comes back from vacation |
e4a1e2b
to
59aeb32
Compare
@timolegros my question is what direct onchain requests do we actually make on custom domains / how large is the breakage surface area in practice? |
e1817ba
to
a56be87
Compare
a56be87
to
b9c4cb3
Compare
|
@timolegros @kurtisassad IMO it is acceptable to get custom domain automation out where growth needs to make an eng request if stake/contest support is needed. Better than the current flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just 2 quick suggestions.
packages/commonwealth/client/scripts/views/pages/AdminPanel/UpdateCustomDomainTask.tsx
Show resolved
Hide resolved
# Conflicts: # libs/model/src/middleware/authorization.ts # libs/schemas/src/commands/community.schemas.ts # packages/commonwealth/client/scripts/views/pages/AdminPanel/UpdateCustomDomainTask.tsx # packages/commonwealth/server/api/community.ts
packages/commonwealth/client/scripts/state/api/communities/updateCustomDomain.tsx
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/pages/AdminPanel/RefreshCustomDomainTask.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments but looks good to me in general, didn't test it manually though
ed8c79b
to
ac6ab4f
Compare
Link to Issue
Closes: #8226
Closes: #7683
Description of Changes
Test Plan
Deployment plan