Change stake modal to text input #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianrowan
requested review from
jnaviask,
mhagel,
kurtisassad,
masvelio and
lzach83
masvelio
requested changes
Feb 21, 2024
There was a problem hiding this comment.
- I bought one stake and I am getting 4e-8 ETH. Not sure if this issue is because of this PR or not, but it worked fine earlier.
- I am concerned about this idea in general as it has a lot of potential issues that are already visible, both on technical and visual sides. I would say it needs better thought and maybe input from design team. I am listing some pitfalls I run into
- I am able to delete value from the input and a. it becomes without value on blur and b. it gives me 2 console errors because fundamental rules of react inputs are violated
Kapture.2024-02-21.at.13.52.47.mp4
-
I can type non numeric values
-
I can type very long numbers which breaks both design and functionality
-
it looks bad on mobile in such cases (layout was not prepared for such a big numbers)
In my opinion, it cannot get in with this shape. I think we should
- use number input
- add proper validation for max number values
- figure out better UI for mobile or/and big numbers
...lient/scripts/views/modals/ManageCommunityStakeModal/StakeExchangeForm/StakeExchangeForm.tsx
Outdated
Show resolved
Hide resolved
...lient/scripts/views/modals/ManageCommunityStakeModal/StakeExchangeForm/StakeExchangeForm.tsx
Outdated
Show resolved
Hide resolved
...lient/scripts/views/modals/ManageCommunityStakeModal/StakeExchangeForm/StakeExchangeForm.tsx
Show resolved
Hide resolved
masvelio
approved these changes
Feb 22, 2024
ilijabojanovic
pushed a commit
that referenced
this pull request
Feb 22, 2024
* input + gas optimization * use loose equality * block alphabetic input * set max value that fits on mobile + fix characters * convert to new designs * css tweaks --------- Co-authored-by: Marcin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6766
Description of Changes
https://www.loom.com/share/61e1cc9e926f44228becc4195b310bb2
-bonus: includes an optimization for suggested gas in txs + add base as a network fix
Test Plan
Other Considerations