Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting first batch of commands and queries to new framework #6790

Merged
merged 22 commits into from
Feb 21, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Feb 17, 2024

We're in the process of porting the initial batch of commands and queries to our new layered framework to identify any gaps and uncover additional opportunities for improvement.

Link to Issue

Closes: #6821

Description of Changes

  • Porting community stake and group commands
  • Model simpler unit testing conventions
  • Adds dependency cruiser tool and configuration to generate dependency graph
  • Moves port factories to port.ts so we can use the logger port to log adapter lifecycle events and errors

Additional Context

  • We are leaving TODO comments in areas that need further development, like async integrations
  • After a few more rounds, we should be able to decide if we want to move forward with this framework, and find strategic areas to port first (like authorized queries).

@github-actions github-actions bot marked this pull request as draft February 17, 2024 15:59
@Rotorsoft Rotorsoft marked this pull request as ready for review February 20, 2024 14:32
Copy link
Contributor

@kurtisassad kurtisassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't get dependency cruiser to work, as it would complain if I upgraded node (since the project is stuck on 18.x). Anyways, rest of the code looks good.

@Rotorsoft Rotorsoft merged commit c9fb618 into master Feb 21, 2024
6 of 7 checks passed
@Rotorsoft Rotorsoft deleted the rotorsoft/framework.use-tbc-service branch February 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port first batch of commands and query to new framework
3 participants