-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize custom_stages
and stages_enabled
#6770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
requested review from
jnaviask,
kurtisassad,
Rotorsoft,
masvelio and
mzparacha
February 15, 2024 21:52
mzparacha
reviewed
Feb 16, 2024
...ews/pages/CommunityManagement/CommunityProfile/CommunityProfileForm/CommunityProfileForm.tsx
Outdated
Show resolved
Hide resolved
mzparacha
reviewed
Feb 16, 2024
...ews/pages/CommunityManagement/CommunityProfile/CommunityProfileForm/CommunityProfileForm.tsx
Show resolved
Hide resolved
mzparacha
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
lzach83
approved these changes
Feb 16, 2024
CowMuon
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for Common release v. 1.0 (nee v0.9.6)
jnaviask
pushed a commit
that referenced
this pull request
Feb 16, 2024
* stages_enabled column fixes * custom_stages fixes * validate custom stages array in API * fix client/API custom stages * type fixes * fix migration * disallow single quotes in validation * remove quote replacement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6718
Description of Changes
Community.stages_enabled
column type from string to booleanCommunity.custom_stages
column type from string to array of stringscustom_stages
Test Plan
Requires
FLAG_NEW_ADMIN_ONBOARDING=true
to be set. Also requires a fresh database dump (yarn dump-db
).yarn db-all
Other Considerations
The migration includes queries that convert
custom_stages
to an array of strings for specific communities. This is because there is no easy/clean generalized approach for converting these values. It is important to note that should these values change for the community before this migration is run, the migration may fail. That said, the client currently in production already includes validation for 99% of cases. There are 2 ways an incorrect value could be inserted: