Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed creation account function calls #6762

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #6760

Description of Changes

The onSaveProfileInfo and onCreateNewAccount were receiving click events when called from HTML elements in the login modal, this broke the account creation step in the old modal.

Now we correctly call onSaveProfileInfo and onCreateNewAccount in the old login modal.

"How We Fixed It"

By correctly calling onSaveProfileInfo and onCreateNewAccount

Test Plan

  • Clear DB
  • Visit any page of the app
  • Login with any wallet
  • Verify that you can successfully create a new account.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft February 15, 2024 17:28
@mzparacha mzparacha marked this pull request as ready for review February 15, 2024 17:28
Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Contributor

@rbennettcw rbennettcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the bug, however the profile shows as "Anonymous" when first signed in, even though a profile name is set. Can fix now or in a followup later.

@mzparacha
Copy link
Contributor Author

This does fix the bug, however the profile shows as "Anonymous" when first signed in, even though a profile name is set. Can fix now or in a followup later.

I noticed that on reloading the page it uses the name entered by user. Will fix it in a followup.

@mzparacha mzparacha merged commit 3609d69 into master Feb 15, 2024
7 of 8 checks passed
@mzparacha mzparacha deleted the malik.6760.fix-account-creation branch February 15, 2024 17:56
jnaviask pushed a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metamask does not sign in post-account creation until refresh
3 participants