Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6715 - Bug: Combination of bold, italic, and strikethrough is wonky #6761

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Miaplacidus
Copy link
Contributor

The following rendered as expected: ~~***words***~~. This, however, did not: ***~~words~~***
This PR updates the styling so that the two render correctly, i.e. italicized, bold, and with a strikethrough.

Link to Issue

Closes: #6715

Description of Changes

  • adds necessary css to style tags

"How We Fixed It"

  • updated styling for strong tags

Test Plan

  • in our editor, enter ***~~words~~*** and ~~***words***~~. Confirm in preview that the text has italic, bold, and strikethrough styling

@Miaplacidus Miaplacidus marked this pull request as ready for review February 15, 2024 17:08
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
image

@jnaviask jnaviask merged commit 3f74acf into master Feb 16, 2024
7 of 8 checks passed
@jnaviask jnaviask deleted the 6715.ifu.editor-combo-styling branch February 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants