Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divastaking delegate button fix #6748

Closed
wants to merge 2 commits into from
Closed

Divastaking delegate button fix #6748

wants to merge 2 commits into from

Conversation

mw2000
Copy link
Contributor

@mw2000 mw2000 commented Feb 15, 2024

Link to Issue

Closes: #6277

Description of Changes

  • Checks if a contract is a GovernorCountingSimple type by its abi and blocks Delegate button being shown if it is.

"How We Fixed It"

  • Created a small function to check the abi of the current contract in the community

Test Plan

  • Join Divastaking community and check if delegate tab is present

@mw2000 mw2000 linked an issue Feb 15, 2024 that may be closed by this pull request
Delegate tab Unnecessary in Diva Staking Community #6277
Closed
@mw2000 mw2000 marked this pull request as ready for review February 15, 2024 04:27
@jnaviask
Copy link
Collaborator

jnaviask commented Mar 1, 2024

Superseded by #6963

@jnaviask jnaviask closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzparacha mzparacha Awaiting requested review from mzparacha

@CowMuon CowMuon Awaiting requested review from CowMuon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegate tab Unnecessary in Diva Staking Community
2 participants
@mw2000 @jnaviask