Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature flag for homepage directing to dashboard #6747

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Added feature flag for homepage directing to dashboard #6747

merged 2 commits into from
Feb 20, 2024

Conversation

kurtisassad
Copy link
Contributor

@kurtisassad kurtisassad commented Feb 15, 2024 •
edited
Loading

Link to Issue

Closes: #6534

Description of Changes

  • Makes the root domain direct to the user dashboard

Test Plan

  • Add ROOT_DOMAIN_REBRAND=true to your .env and go to localhost:8080. It redirects to the /dashboard/global
  • Go to some other page, click on the top left icon, it will redirect to /dashboard/global

Deployment Plan

  1. Ideally this goes in with the unleash feature flagging. Then we can "flip the switch" as suggested in the ticket

masvelio
masvelio approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, looks good otherwise

packages/commonwealth/client/scripts/helpers/feature-flags.ts Outdated Show resolved Hide resolved
Miaplacidus
Miaplacidus approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@Miaplacidus Miaplacidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtisassad kurtisassad merged commit 7f94126 into master Feb 20, 2024
6 of 7 checks passed
@kurtisassad kurtisassad deleted the ka.userDashboardHomepage branch February 20, 2024 16:20
jnaviask pushed a commit that referenced this pull request Feb 23, 2024
@kurtisassad @jnaviask
Added feature flag for homepage directing to dashboard (#6747)
e880890
CowMuon
CowMuon reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@CowMuon CowMuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G (Product wants this shipped today kudasai)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CowMuon CowMuon CowMuon left review comments

@masvelio masvelio masvelio approved these changes

@Miaplacidus Miaplacidus Miaplacidus approved these changes

@mzparacha mzparacha Awaiting requested review from mzparacha

@lzach83 lzach83 Awaiting requested review from lzach83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Marketing Splash Page for Rebrand Launch (Part 1 of 2)
4 participants
@kurtisassad @Miaplacidus @masvelio @CowMuon