Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6714 rendering unordered list #6727

Merged
merged 6 commits into from
Feb 14, 2024
Merged

6714 rendering unordered list #6727

merged 6 commits into from
Feb 14, 2024

Conversation

lzach83
Copy link
Contributor

@lzach83 lzach83 commented Feb 13, 2024

Link to Issue

Closes: #6714

Description of Changes

  • Modified the CSS to display all types of lists

"How We Fixed It"

  • Made the default list none
  • Explicitly set the checkbox style as a checkbox

Test Plan

  • Go to create a thread or reply to a thread
  • Copy the following:
- Test bullet1
- Test bullet 2
- Test bullet 3
- [ ]  Test checkbox 1
1. Test number 1
2. Test number 2
  • Ensure the format is correct

@lzach83 lzach83 self-assigned this Feb 13, 2024
Israellund
Israellund approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnaviask
Copy link
Collaborator

Should go into 0.9.5.

@jnaviask jnaviask merged commit 61a7e00 into master Feb 14, 2024
6 of 7 checks passed
@jnaviask jnaviask deleted the 6714-renderingUnorderedList branch February 14, 2024 16:45
jnaviask pushed a commit that referenced this pull request Feb 14, 2024
@lzach83 @jnaviask
6714 rendering unordered list (#6727)
aeb96c7 
* Saving my spot, am able to render correctly but is not copying to clipboard saving formatting

* Modified the css

* remove docker

* Revert "remove docker"

This reverts commit acd69d7.

* removed the wrong docker

* Unused css class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israellund Israellund Israellund approved these changes

@jnaviask jnaviask jnaviask approved these changes

@Miaplacidus Miaplacidus Awaiting requested review from Miaplacidus

@mzparacha mzparacha Awaiting requested review from mzparacha

@CowMuon CowMuon Awaiting requested review from CowMuon

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees

@lzach83 lzach83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unordered lists not rendering correctly when with other types of lists
3 participants
@lzach83 @jnaviask @Israellund