Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added iOS social login #6708

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Added iOS social login #6708

merged 2 commits into from
Feb 14, 2024

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #6509

Description of Changes

  • Adds iOS/apple login in the new AuthModal -> "Email or social" tabs

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_NEW_SIGN_IN_MODAL in .env
  • Logout, visit any page in the app and open AuthModal -> "Email or social" tabs
  • Click on the "Apple" button and verify that it logs you in correctly.

Deployment Plan

N/A

Other Considerations

N/A

@mzparacha mzparacha self-assigned this Feb 12, 2024
@mzparacha mzparacha marked this pull request as ready for review February 12, 2024 18:42
@mhagel
Copy link
Contributor

mhagel commented Feb 12, 2024

I found a bug unrelated to your change. Just a 1-liner, so I committed it here. 73be644

Copy link
Contributor

@mhagel mhagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with iphone. Worked great.

@dillchen
Copy link
Contributor

dillchen commented Feb 12, 2024

Works for me


Out of scope

  1. Discuss which login options to show users on mobile (show a subset of wallet and social)
  2. Figure out later on how we get a better flow on finishSocialLogin it's so slow, half magic's fault, but otherwise things we could fix
  3. Getting this when testing locally - finish social login just took a long time after this and worked:
image

@dillchen dillchen self-requested a review February 13, 2024 01:42
@mzparacha mzparacha merged commit 9b68ed1 into master Feb 14, 2024
6 of 7 checks passed
@mzparacha mzparacha deleted the malik.6509.ios-magic-login branch February 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎯 Add iOS Magic
3 participants