Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated env feature flags to openfeature #6702

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

kurtisassad
Copy link
Contributor

@kurtisassad kurtisassad commented Feb 12, 2024

Link to Issue

Closes: #6701

Description of Changes

  • Migrates old feature flag system to use openfeature.

Test Plan

With the .env:

FLAG_COMMUNITY_STAKE=true
FLAG_NEW_ADMIN_ONBOARDING=true
  • Check community stakes by creating a staked community with the sepolia chain node.
  • Create community and check that the new admin onboarding section appears

@kurtisassad kurtisassad requested review from masvelio, mzparacha, Israellund and Rotorsoft and removed request for masvelio February 12, 2024 14:10
@kurtisassad kurtisassad marked this pull request as draft February 12, 2024 14:24
@kurtisassad kurtisassad force-pushed the ka.openFeature branch 2 times, most recently from 25eddd9 to cc1897c Compare February 12, 2024 14:49
@kurtisassad kurtisassad marked this pull request as ready for review February 12, 2024 15:50
@jnaviask
Copy link
Collaborator

@kurtisassad deployment plan? What new infra does this involve? How is it managed?

@kurtisassad
Copy link
Contributor Author

@jnaviask This particular PR has no required deployment plan. The overall deployment plan will be:

  1. Merge this PR (This converts our .env usage to use the openfeature interface)
  2. Merge this PR and follow it's required deployment Added unleash provider for openconfig #6707 (This adds unleash as the implementation for production)

The reason for this is that some developers have expressed that they would like to continue using the old .env feature flag for local development instead of being forced to connect to our unleash server.

package.json Outdated Show resolved Hide resolved
@Rotorsoft
Copy link
Contributor

Looks good to me, but would prefer if @masvelio reviews and approves UI changes.

Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

we have this warning in the console now, which might lead to not expected behaviours in the future. Related to this

Apart from it, it looks good and seems to work fine as well. So to understand it correctly. My local .env will always override the flag value from the unleash?

packages/commonwealth/client/scripts/App.tsx Outdated Show resolved Hide resolved
@kurtisassad
Copy link
Contributor Author

My local .env will always override the flag value from the unleash?

Correct

Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kurtisassad kurtisassad merged commit 29763c3 into master Feb 13, 2024
6 of 7 checks passed
@kurtisassad kurtisassad deleted the ka.openFeature branch February 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openfeature migration
4 participants