-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated env feature flags to openfeature #6702
Conversation
a1701dc
to
fbe982b
Compare
25eddd9
to
cc1897c
Compare
cc1897c
to
e90d186
Compare
@kurtisassad deployment plan? What new infra does this involve? How is it managed? |
@jnaviask This particular PR has no required deployment plan. The overall deployment plan will be:
The reason for this is that some developers have expressed that they would like to continue using the old .env feature flag for local development instead of being forced to connect to our unleash server. |
Looks good to me, but would prefer if @masvelio reviews and approves UI changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have this warning in the console now, which might lead to not expected behaviours in the future. Related to this
Apart from it, it looks good and seems to work fine as well. So to understand it correctly. My local .env will always override the flag value from the unleash?
Correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Link to Issue
Closes: #6701
Description of Changes
Test Plan
With the .env: