Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix to handle errors in ddd routes #6663

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Hotfix to handle errors in ddd routes #6663

merged 1 commit into from
Feb 8, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Feb 8, 2024 •
edited
Loading

Attach error handler to ddd routes, with proper try/catch in adapters

Link to Issue

Closes: #6664

Description of Changes

  • Fix express adapters
  • Rename guards

@github-actions github-actions bot marked this pull request as draft February 8, 2024 18:54
@Rotorsoft Rotorsoft marked this pull request as ready for review February 8, 2024 18:58
@Rotorsoft Rotorsoft merged commit 019de34 into master Feb 8, 2024
7 of 8 checks passed
@Rotorsoft Rotorsoft deleted the rotorsoft/hotfix.fix-ddd-routes branch February 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error handler in ddd routes
3 participants
@Rotorsoft @kurtisassad @rbennettcw