-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added valentine growl #6657
Added valentine growl #6657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate the detail level in testing instructions, @mzparacha
This appears to do the thing- can we ship this, with gating growl removal 6517 as patch 0.9.4-4 @ilijabojanovic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilijabojanovic can you try on port 8080? |
Still same on 8080. |
For what its worth it works for me, but mine goes through google calendar. Maybe it breaks on the macos calendar app? |
Works for me @ilijabojanovic, I am not sure what the issue on your side is. test.mp4 |
Approved to ship, but good catch @ilijabojanovic, this was exactly what we were discussing in parking lot, that it's not uncommon for cal invite handling to have a lacuna between web calendars and locally installed calendar apps. We said on that call we're good with users having to take extra steps. I haven't tested on Frick or Frack tho it looks like Ilija's error is local only. |
Pushed to frack for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified on frack
* Added valentine growl * Added invite info
Link to Issue
Closes: #6636
Description of Changes
"How We Fixed It"
N/A
Test Plan
Deployment Plan
N/A
Other Considerations
N/A