Apply port adapter pattern to mixpanel analytics #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we need to frequently parse the request context to extract browser info to append to the analytics payload, it's convenient to wrap the cc @Rotorsoft |
|
I think there may still be some dangling analytics calls that don't use the controller– checking… |
Rotorsoft
reviewed
Feb 8, 2024
Rotorsoft
approved these changes
Feb 8, 2024
|
Also, "mixpanel": "^0.14.0" dependency should be move to libs/adapters to keep this clean |
kurtisassad
reviewed
Feb 13, 2024
|
@rbennettcw LGTM, initializing logger inside adapter 👍 |
kurtisassad
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6421
Description of Changes
Test Plan
N/A
Deployment Plan
N/A
Other Considerations
N/A