[Experimental] merge master into 2.0 #4947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* super admins update admins * Bump yarn.lock. --------- Co-authored-by: Jake Naviasky <[email protected]>
* Migrated thread add/delete reaction queries to react query * Migrated comment add/delete reaction queries to react query * Migrated fetch comment reactions query to react query * Merged reaction controller state with comments controller * Migrated (half) reactionCounts query to react query files * Fix type check * Code linted and updated letter case for some func * removed extra comment * Remove .then from react query queries * Removed extra modelFromServer utils for comments, reactions and reaction counts * Moved comments CRUD state to react query * Added dedicated reactionCounts store for comments, threads and proposals * Cleanup comment controller methods * Temporarily moved remaining reactions store code to threads controller * Fixed code style issues * Linted <CommentTree/> * Use camelCase in comments modal * Removed attachments[] key from comments * Fix comments rq state after addComment call * Use map instead of findIndex when updating state after editComment * Regenerate lockfile. --------- Co-authored-by: Jake Naviasky <[email protected]>
* remove Attachments from API * migration wip * fix migration to remove attachments * remove attachments from orm * add missing error * remove file * Fix undo migration. --------- Co-authored-by: Jake Naviasky <[email protected]>
* Added assertion to CI to assert yarn lock is correct * Moved the yarn.lock check into the code quality job
* Prepared UI for user dropdown * Dropdown cleanup * update navigation * Update logout * Fix tslint --------- Co-authored-by: Marcin Maslanka <[email protected]>
* first commit * add storybook story * edit Tooltip story * fix Neue Haas Unica storybook font * add 4 tooltips to same story * removed scss import * removed padding-bottom * edit text vertical aligment * removed joy ui, add popover tooltip * add margin * add text formatting * add border none * PR review: fix styling * add multiline ellipsis * edit old tooltip class name --------- Co-authored-by: Jake Naviasky <[email protected]>
* remove DiscussionDrafts model * remove old drafts test
* add spam column and endpoints for threads/comments * update routes * update client models with markedAsSpamAt * update client models for markedAsSpamAt * Updated thread card ui * Refactored + Cleanup thread discussion components with new styles and ui * Use event listeners to update state in discussions page * Refactored thread details container to use new options and metadata components * Removed custom app.threadEventEmitter * Use permissions util * Moved reaction button to thread card + reorganized thread card * Updated icons + polished ui * Updated checkbox UI * Resturctured thread card comps * Updated confirmation modal styles * Added spam filter toggle to discussion screens * Refactored comment card and tree to reduce complexity * Updated comment card footer ui * Added mark as spam for thread * Added mark comment as spam * Updated bulkThreads to return marked_as_spam_at field * Added option to toggle spam threads on discussion page * Show thread options for all threads on thread card * Added option to toggle spam comments on view thread page * Restructured thread filter header * Removed extra filter css * Fix thread card body click * Fix comment action delete color * Allow site admins to mark as spam. * Added ui to unflag comment/threads as spam * add endpoints to unmark thread/comment as spam * Connected api to unmark spam thread * Connected api to unmark spam comment * Updated comment spam modal message * Refactored discussions page to use useNecessaryEffect hook * Fix virtuoso infinite scroll bug * Bump migration date. * Use <Link> instead of <a> on thread card * Show comments spam toggle only when there are comments * Fix lock icon * Fail e2e tests * Update colors with new variables * Fix e2e tests * Fixed unresolved merge issues * Fix thread list view on stage change * Added pagination params to bulkThreads * Updated padding for large screens * Added skeleton ui to discussion page * Added skeleton ui to overview page * Updated e2e tests for landing page * Added skeleton loading state for view thread page * Sort comments by recency (#4294) * Sort comments by recency * Added compact variant for select dropdown * Added mobile styles for comment filter row * Add mobile styles for discussion page skeleton ui * Updated mobile design for view thread page skeleton * Added skeletoon ui tests for discussion page * Fix code quality CI * Removed falky skeleton ui test * Bump yarn.lock. --------- Co-authored-by: Ryan Bennett <[email protected]> Co-authored-by: Jake Naviasky <[email protected]>
Co-authored-by: Marcin Maslanka <[email protected]>
* databaseCleaner init + migration revert * databaseCleaner clean-up functions + added to server.ts * dbCleaner use UTC + tests * name fix in CI * clean-up test logs + don't leave setTimeout funcs hanging * clearer log for undefined hourToRun * migration reversal * drop NR fkey constraints * migration init * Remove EntityEvent from NotificationsCategories enum * rename migration to make it latest * reorder migration * remove new-community-creation new-role-creation and new-snapshot NotificationCategories * migration logs * remove migration logs + rename migration * rename/reorder migrations
* In CI, skip test that relies on devnet state * Delete test that relies on unreliable csdk-beta devnet state * update juno rpc, make cache test easier to change * testServer rpc update
* Prevent reacting to locked and archived threads * Simplified canReact logic fopr thread + lint code --------- Co-authored-by: Jake Naviasky <[email protected]>
* add browser info to API mixpanel events * detect brave * update yarn lock * fix unit test * update old analytics call with new * fix imports * add comments * cleanup
* Fixed Admin UI visibility on createChain * Added tests for createCommunity * Fixed type errors * Added utils to add or remove user for e2e tests * Fixed issue with login order for e2e tests * Added check to fix e2e login * Reworked e2e test structure * Fixed failing e2e tests * Added e2e video recording upload step to CI * commented out e2e tests to try fresh run * Fixed e2e tests * Re-added commented out e2e tests * Increase test timeout for createCommunity * Fixed PR comments * Fixed test timeout * Fixed login locators * Made createCommunity tests run in parallel * Reduced createCommunity test conflicts * Removed unused imports * Fixed flaky playwright tests * Used alternative way to skip deinit between createCommunity and community navigation * Improved code comment * Fixed race condition in e2e tests * Fixed issue with createChain --------- Co-authored-by: Jake Naviasky <[email protected]>
* Initial migration * Name updates * File name cleanup pass * Update Devnet docs from Mark * Update Agile Development entry --------- Co-authored-by: Jake Naviasky <[email protected]>
* Move thread metadata after quill editor in edit mode * Moved thread author/publish info above quill editor in edit mode
* update profile component to limit itself to 3 sizes * remove size guesses from components * update avatar sizes for popover and where conditional
* fix form toggle to select communitySpend * Display communitySpend params if available * display community spend details
* databaseCleaner init + migration revert * databaseCleaner clean-up functions + added to server.ts * dbCleaner use UTC + tests * name fix in CI * clean-up test logs + don't leave setTimeout funcs hanging * clearer log for undefined hourToRun * migration reversal * drop NR fkey constraints * migration init * Remove EntityEvent from NotificationsCategories enum * rename migration to make it latest * remove offchain prefix from subscriptions model * post-merge fixes * reorder migration * remove new-community-creation new-role-creation and new-snapshot NotificationCategories * migration logs * remove migration logs + rename migration * rename/reorder migrations * rename/reorder migrations * rename index on thread_id * reorder migration * add if exists
* admins delete disco posts * admins can delete comments on discobot posts
active 10 seconds, inactive 30 seconds return empty array if not cosmos use 'fetching' status use default loading, show spinner if cosmos and rq-loading
* add disabled state for preview modal when blank content * code cleanup * code cleanup * edit props
* Updated thread patch to use the updated unified api * Fix thread topic update * Updated edit thread params * Fix cache type error. --------- Co-authored-by: Jake Naviasky <[email protected]>
* - upgrade cosmjs to 0.31.0, use createAltGovAminoConverters to register CommunitySpend in MsgSubmitProposal - encodeCommunitySpend to utils, devnet tests for communitySpend - DRY up tests and add amino tests for all - null check for mindeposit.denom to fix intermittent bug * Bootstrap mod (#4872) fix dasel syntax unstaked tokens visible in keplr fix platform for docker update wiki new image ref for CI tests * migration for more keplr-friendly chain names
…of the wiki (#4866) * Rm unused docs files, update TOC, add wishlist * Update local wiki to all GH wiki changes * Audit, cleanup * Rm Wallet stub * Update tags, update standup info, tidy
… card (#4861) * Focus comment editor on view thread page on comment btn click in thread card * Fix editor focus on view threads page
* Initial migration * Name updates * File name cleanup pass * Docs pass * Package documentation progress * Add first pass TOC * TOC * Add more script docs * Add mobile script documentation, add ts-node sections, reorganize * Webpack bundler documentation * Add new Playwright scripts * Update dump-db script * Add clean-db and integration testing script docs * Round out test documentation * Add final db scripts, delete old package doc file * Add Consumer documentation, penultimate pass * Cleanup pre-PR --------- Co-authored-by: Jake Naviasky <[email protected]>
* Added timeout to tests to avoid CI from hanging * Increased CI timeout
* Persist selected account * Persist selected account --------- Co-authored-by: Marcin Maslanka <[email protected]>
* wip * remove user lastVisted property * fix database cleaner query * cleanup * lint * add user updated_at to query * Bump linter memory. * Fix undefined crash in status route. * fix e2e maybe --------- Co-authored-by: Jake Naviasky <[email protected]>
* Initial migration * Name updates * File name cleanup pass * Docs pass * Package documentation progress * Add first pass TOC * TOC * Add more script docs * Add mobile script documentation, add ts-node sections, reorganize * Webpack bundler documentation * Add new Playwright scripts * Update dump-db script * Add clean-db and integration testing script docs * Round out test documentation * Add final db scripts, delete old package doc file * Add Consumer documentation, penultimate pass * Cleanup pre-PR * Rm code style req md * Separate out linting info --------- Co-authored-by: Jake Naviasky <[email protected]>
* first commit * adds community name to Tab title * edit Tab title when on /discussions * edit Tab title when on /proposals * edit Tab title when on a View Proposal Page * edit Tab title when on /snapshot/[spaceId] * edit Tab title when on a View (not-snapshot) Proposal Page * add useManageDocumentTitle hook * code cleanup * removed conditional hook call * fixed hook dependency * edit hook with dependencies * fix linting * edit hook
* use EthSigningClient if one of ethermint chains add cosmos/gov controllers to CI devnet check add REST urls for evmos and injective add remote image to CI LCD: do not cache broadcast or TX query default cache 0: do not cache unless specified add sandbox to migration use mnemonic generated by evmosd cli bump keplr types * docs updates
* remove unused routes * fix thread integration tests WIP * add tests to update thread * bump lint mem * update server test * restore rollbar * fix server test * remove outdated topic test
…ification Tests (#4586) * databaseCleaner init + migration revert * databaseCleaner clean-up functions + added to server.ts * dbCleaner use UTC + tests * name fix in CI * clean-up test logs + don't leave setTimeout funcs hanging * clearer log for undefined hourToRun * migration reversal * drop NR fkey constraints * migration init * Remove EntityEvent from NotificationsCategories enum * rename migration to make it latest * remove offchain prefix from subscriptions model * post-merge fixes * move NotificationDataTypes * consolidate ISnapshotNotificationData * remove ICommunityNotificationData * delete unused helper * convert NotificationCategories to an enum and create NotificationCategory * rename IPostNotificationData to IForumNotificationData and add NotifCategoryToNotifDataMapping * init subscriptionMapping * reorder migration * remove new-community-creation new-role-creation and new-snapshot NotificationCategories * migration logs * remove migration logs + rename migration * rename/reorder migrations * rename/reorder migrations * create individual notification data interfaces * convert emitNotifications to use NotificationDataAndCategory * remove category_id as param from emitNotifications * add user id to NewMention/NewCollab notifData and finish notifData to sub mapping func * notificationDataToSubscription finish * remove object_id as emitNotifications parameter * delete auto-subscribe new-thread subs to comments on new threads * removed object_id from server side * create subscription function * replace `models.Subscription.create` with `createSubscription` function * findSubscription function init * remove Notification dependency on NotificationSubscription * remove thread_id and comment_id from fromJSON func in NotificationSubscription.ts * refactor createSubscription + remove NotificationSubscription.ts id ambiguity + require chain_id for new-comment/reaction * add types for finding subscriptions * remove public access to subscriptions array + rename NotificationCategories in viewNotifications for clarity + update subscribe calls * category -> category and unit test fixes * revert createSubscription replacement and override Subscription.create instead * passing CW unit tests * func docs * passing integration tests * fix emitNotifications tests * fix databaseCleaner tests * mapNotificationsDataToSubscriptions tests * move subscriptionMapping.ts * move findSubscription * rename emitOptions notificationData to notification * checkSubscriptionValues unit tests * notificationData -> notification in tests * new-thread subscription tests + createSubscription fixes * /createSubscription tests * finished subscription tests * preliminary notification route tests + migration update + markNotificationsRead fix * client bug fixes * stop half filled sub from being created to force refresh * override Subscription.findOrCreate and require chain_id for new-reaction + new-comment in `/createSubscription` + test case for chain_id * revert require chain_id for new-reaction + new-comment in `/createSubscription` + test case for chain_id * type fix * IForumNotifcationData todo * remove .only * findSubscription tests + move subscription related unit tests + findSubscription fix * remove .only unit test * remove unnecessary webhook check * added chain-event emitNotifications test + fixed CE notif email * added DB level constraints for Subscriptions * update comment * remove checkSubscriptionValues in favor of db level check constraints * Subscription model validation + tests * add test for mention and collaboration emitNotification * ensure all CI tests are running * type fix in test * reorder migration + delete duplicate * fix notifications tests * update comment * transfer QA doc to wiki * validation function comment * directly map request parameters * Linter fix. --------- Co-authored-by: Jake Naviasky <[email protected]>
* fixes * fixes * sort by latest activity
* add struct support * fix lint issues
* Only show skeleton once on discussion page * Added option to keep previous data while fetching new threads
* Made domain and status calls be run in parallel * Fixed custom domain logic * Fixed double calls of status and domain * Added to test to assert only 2 api calls are made on landing page * Removed redundant .then --------- Co-authored-by: Jake Naviasky <[email protected]>
* Added skeleton to home feed * Fix type import
# Conflicts: # packages/commonwealth/client/scripts/controllers/server/notifications.ts # packages/commonwealth/client/scripts/controllers/server/threads.ts # packages/commonwealth/client/scripts/hooks/useInitApp.ts # packages/commonwealth/client/scripts/models/NotificationSubscription.ts # packages/commonwealth/client/scripts/state/index.ts # packages/commonwealth/client/scripts/views/SublayoutHeader.tsx # packages/commonwealth/client/scripts/views/components/Comments/CreateComment.tsx # packages/commonwealth/client/scripts/views/components/ReactionButton/helpers.tsx # packages/commonwealth/client/scripts/views/components/feed.tsx # packages/commonwealth/client/scripts/views/components/sidebar/index.tsx # packages/commonwealth/client/scripts/views/pages/discussions/ThreadCard/ThreadOptions/ReactionButton/useReactionButton.tsx # packages/commonwealth/client/scripts/views/pages/user_dashboard/FeedRow/UserDashboardRowTop.tsx # packages/commonwealth/client/scripts/views/pages/user_dashboard/user_dashboard_chain_event_row.tsx # packages/commonwealth/client/scripts/views/pages/user_dashboard/user_dashboard_row.tsx # packages/commonwealth/client/scripts/views/pages/user_dashboard/user_dashboard_row_bottom.tsx # packages/commonwealth/client/scripts/views/pages/view_thread/ViewThreadPage.tsx # packages/commonwealth/client/scripts/views/pages/view_thread/linked_proposals_card.tsx # packages/commonwealth/client/styles/SublayoutHeader.scss # packages/commonwealth/client/styles/components/sidebar/index.scss # packages/commonwealth/package.json # packages/commonwealth/server/database.ts # packages/commonwealth/server/models/subscription.ts # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed in order to test my other PR changes with latest master.
Description of Changes
"How We Fixed It"
Test Plan
FIXME()call.Deployment Plan
Other Considerations