-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Quill Markdown #3246
React Quill Markdown #3246
Conversation
Done:
Next steps:
|
The editor now supports markdown and richtext– the last important thing to do is handle serializing for saving to the DB. Currently, the editor state is represented only as a I'm working on handling this without increasing complexity outside the react quill component. |
Markdown support generally works now and I think this is ready to merge. One thing that's unresolved: toolbar buttons don't work properly in markdown mode. I'm working on it, but I think maybe it can be pulled out into another ticket and this PR can be merged as-is so we can get the code out into the wild and tested. Also note: there's a small flash when switching between markdown and richtext mode, due to a bug in the React Quill library that forces us to use a workaround to rerender the component. There's a potention fix for it, but it's not part of the main branch of the library: zenoamaro/react-quill#838 |
Pausing further work on this due to: #2900 |
That's a bummer. @rbennettcw Let's close the PR and hopefully get back to it in post-react |
@jnaviask Agreed that this should probably be closed. Although markdown is technically implemented in an MVP state, this PR will require a bit more work to reach full parity with production, and some testing across multiple impacted features. If velocity and stability is the priority, then it's best not to merge this, and probably to close it. |
Adds markdown support to the
ReactQuillEditor
component and updates parent components to support the new functionality via serialization/deserialization of text.Link to Issue
Closes: #2933
Description of Changes
Test Plan
Deployment Plan
N/A
Other Considerations