HHH-19036 Process all filters before going through classes

[marko-bekhta]

https://hibernate.atlassian.net/browse/HHH-19036

This already works fine in 7.0 since the switch to models and having this:

hibernate-orm/hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/annotations/AnnotationMetadataSourceProcessorImpl.java

Lines 170 to 177 in f0bfef9

	public void processFilterDefinitions() {
	final Map<String, FilterDefRegistration> filterDefRegistrations = domainModelSource.getGlobalRegistrations().getFilterDefRegistrations();
	for ( Map.Entry<String, FilterDefRegistration> filterDefRegistrationEntry : filterDefRegistrations.entrySet() ) {
	final FilterDefRegistration filterDefRegistration = filterDefRegistrationEntry.getValue();
	final FilterDefinition filterDefinition = filterDefRegistration.toFilterDefinition( rootMetadataBuildingContext );
	rootMetadataBuildingContext.getMetadataCollector().addFilterDefinition( filterDefinition );
	}
	}

I did consider doing the pass over classes in the processFilterDefinitions method as well for 6.6, but it feels a bit redundant to generate the orderedClasses = orderAndFillHierarchy( xClasses ) two times, or alternatively going through xClasses + their super types... so this seems like a good compromise, no ?

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[mbladel]

This already works fine in 7.0 since the switch to models

Would be great to add the same test there, so we can ensure no regression are introduced in the future.

I did consider doing the pass over classes in the processFilterDefinitions method as well for 6.6, but it feels a bit redundant to generate the orderedClasses = orderAndFillHierarchy( xClasses ) two times

We could cache the orderedClasses in a local property, and initialize them lazily the first time they're needed:

private List<XClass> getOrderedClasses() {
	if ( orderedClasses == null ) {
		orderedClasses = orderAndFillHierarchy( xClasses );
	}
	return orderedClasses;
}

You're approach looks fine anyway, this would just be a way of making processFilterDefinitions actually do the thing 😄

[marko-bekhta]

added a test for main here #9943