HHH-19293 Criteria isMember() doesn't work with collections mapped as array #9918
Conversation
| cb.isMember( UserWithArray.Role.Admin , root.get( "roles" ) ), | ||
| cb.isMember( cb.literal( UserWithArray.Role.Admin ), root.<Collection<UserWithArray.Role>>get( "roles" ) ) |
There was a problem hiding this comment.
Did you try using in() here instead of isMember()?
There was a problem hiding this comment.
Usage of in() fails with an another exception:
org.hibernate.exception.SQLGrammarException: could not prepare statement [Syntax error in SQL statement "select uwa1_0.id,uwa1_0.roles in (cast(? as varchar([*]null) array)) from users uwa1_0 where uwa1_0.id=?"; expected "long"; SQL statement:
select uwa1_0.id,uwa1_0.roles in (cast(? as varchar(null) array)) from users uwa1_0 where uwa1_0.id=? [42001-232]] [select uwa1_0.id,uwa1_0.roles in (cast(? as varchar(null) array)) from users uwa1_0 where uwa1_0.id=?]
at org.hibernate.exception.internal.SQLExceptionTypeDelegate.convert(SQLExceptionTypeDelegate.java:64)
at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:56)
at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:108)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl$StatementPreparationTemplate.prepareStatement(StatementPreparerImpl.java:189)
at org.hibernate.engine.jdbc.internal.StatementPreparerImpl.prepareQueryStatement(StatementPreparerImpl.java:151)
at org.hibernate.sql.exec.internal.StandardStatementCreator.createStatement(StandardStatementCreator.java:47)
at org.hibernate.sql.results.jdbc.internal.DeferredResultSetAccess.executeQuery(DeferredResultSetAccess.java:237)
at org.hibernate.sql.results.jdbc.internal.DeferredResultSetAccess.getResultSet(DeferredResultSetAccess.java:172)
at org.hibernate.sql.results.jdbc.internal.JdbcValuesResultSetImpl.<init>(JdbcValuesResultSetImpl.java:72)
at org.hibernate.sql.exec.internal.JdbcSelectExecutorStandardImpl.resolveJdbcValues(JdbcSelectExecutorStandardImpl.java:380)
at org.hibernate.sql.exec.internal.JdbcSelectExecutorStandardImpl.resolveJdbcValuesSource(JdbcSelectExecutorStandardImpl.java:340)
at org.hibernate.sql.exec.internal.JdbcSelectExecutorStandardImpl.doExecuteQuery(JdbcSelectExecutorStandardImpl.java:141)
at org.hibernate.sql.exec.internal.JdbcSelectExecutorStandardImpl.executeQuery(JdbcSelectExecutorStandardImpl.java:106)
at org.hibernate.sql.exec.spi.JdbcSelectExecutor.executeQuery(JdbcSelectExecutor.java:64)
at org.hibernate.sql.exec.spi.JdbcSelectExecutor.list(JdbcSelectExecutor.java:138)
at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.lambda$new$1(ConcreteSqmSelectQueryPlan.java:149)
at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.withCacheableSqmInterpretation(ConcreteSqmSelectQueryPlan.java:435)
at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.performList(ConcreteSqmSelectQueryPlan.java:368)
at org.hibernate.query.sqm.internal.QuerySqmImpl.doList(QuerySqmImpl.java:367)
at org.hibernate.query.spi.AbstractSelectionQuery.list(AbstractSelectionQuery.java:142)
at org.hibernate.query.Query.getResultList(Query.java:119)
And even if that would work, are you sure that in is the right operation from a semantics point of view? Normally, is in used to check if a singular attribute has one of the multiple values but here I'm trying to check if a multi-valued field (array) has a particular element in it (member).
There was a problem hiding this comment.
Like I wrote on the Jira, the proper way in Criteria is to use the dedicated function array_contains(). The method signatures of in() and isMember() both can't be used in a type-safe way when involving collections/arrays.
There was a problem hiding this comment.
I'm not sure, because it was @beikov who worked on this, but according to the documentation, in is the correct thing in HQL: https://docs.jboss.org/hibernate/orm/7.0/querylanguage/html_single/Hibernate_Query_Language.html#array-functions
There was a problem hiding this comment.
OK, good, Christian responded.
|
Closing, see the Jira discussion. |
Reproducer for HHH-19293
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19293