HHH-19103 add SchemaManager.populate() #9893
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * lists of many {@code insert} statements on the same table, which is what | ||
| * we typically expect, it's probably better to not format. | ||
| */ | ||
| private static Formatter getImportScriptFormatter(boolean format) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -21,6 +21,9 @@ | |||
| SchemaDropper getSchemaDropper(Map<String,Object> options); | |||
| SchemaMigrator getSchemaMigrator(Map<String,Object> options); | |||
| SchemaValidator getSchemaValidator(Map<String,Object> options); | |||
| default SchemaPopulator getSchemaPopulator(Map<String,Object> options) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| Metadata metadata, | ||
| final boolean manageNamespaces, | ||
| GenerationTarget... targets) { | ||
| final ServiceRegistry serviceRegistry = |
There was a problem hiding this comment.
sooo... these were used in Search tests 🥲, not anymore, I guess ...
There was a problem hiding this comment.
Whhaaa? You were testing the SchemaTruncator from Hibernate Search??? What for?
There was a problem hiding this comment.
ohh, no... not testing this method or truncator in general, but using it to clean the test data 🙈
There was a problem hiding this comment.
I mean we're talking about an unused method annotated @Internal of an Impl class in an internal package.
We really need to avoid cross-project dependencies going through methods like that. That's why we define SPIs.
There was a problem hiding this comment.
using it to clean the test data
The you should be using the API for that, not depending on internal implementation details.
If that API doesn't work, then you should propose introduction of an SPI.
Otherwise, when we're working on ORM, we have absolutely no warning that we've done something that might break Search, and indeed, Search deserves to break.
There was a problem hiding this comment.
Do you happen to use the @SessionFactory stuff for testing @marko-bekhta ? If so I added SessionFactoryScope#dropData. Otherwise you could just use sessionFactory.getSchemaManager().truncateMappedObjects()
There was a problem hiding this comment.
ohh Search has a set of its own extensions to deal with tests 🙈 so we don't leverage the @SessionFactory (at least not yet 😉).
Otherwise you could just use sessionFactory.getSchemaManager().truncateMappedObjects()
right ... that's what we do, it's just that we have this extension to deal with a multitenancy, and it has a custom schema manager with overrides, that's where that method was used from 😃.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19103