Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-19256 : Criteria SUM expression return type error #9863

Closed
wants to merge 1 commit into from
Closed

HHH-19256 : Criteria SUM expression return type error #9863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...e-core/src/test/java/org/hibernate/orm/test/jpa/criteria/basic/AggregationResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.math.BigDecimal;
import java.math.BigInteger;
import jakarta.persistence.EntityManager;
import jakarta.persistence.Tuple;
import jakarta.persistence.criteria.CriteriaBuilder;
import jakarta.persistence.criteria.CriteriaQuery;
import jakarta.persistence.criteria.Root;
Expand Down Expand Up @@ -87,6 +88,19 @@
em.close();
}

@Test
public void testTuplesWithSumOfIntegers() {
EntityManager em = getOrCreateEntityManager();
em.getTransaction().begin();
CriteriaQuery<Tuple> criteria = builder.createTupleQuery();
Root<Product> productRoot = criteria.from( Product.class );
criteria.select(builder.tuple( builder.sum( productRoot.get( Product_.quantity ) ) ));
Tuple sumResult = em.createQuery( criteria ).getSingleResult();
assertReturnType( Long.class, sumResult );
Comment on lines +97 to +99
Copy link
Member

@gavinking gavinking Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that Product.quantity is of type Integer, the type of builder.sum( productRoot.get( Product_.quantity ) ) is Expression<Integer>, and the Tuple should contain an Integer and not a Long.

So I believe this assertion is incorrect, and that there's no bug here.

em.getTransaction().commit();
em.close();
}

/**
* Sum of Doubles should return a Double
*/
Expand Down Expand Up @@ -159,4 +173,13 @@
);
}
}

private void assertReturnType(Class expectedType, Tuple value) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note test

Method AggregationResultTest.assertReturnType(..) could be confused with overloaded method
assertReturnType
Loading
, since dispatch depends on static types.
if ( value != null && ! expectedType.isInstance( value.get( 0 ) ) ) {
fail(
"Result value was not of expected type: expected [" + expectedType.getName()
+ "] but found [" + value.get( 0 ).getClass().getName() + "]"
);
}
}
}
Loading