Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-19052 Hibernate 6.6.X regression with join formula #9639

Closed
wants to merge 2 commits into from

Conversation

cigaly
Copy link
Contributor

@cigaly cigaly commented Jan 18, 2025

Jira issue HHH-19052

Method org.hibernate.sql.Template#renderWhereStringTemplate have problems when token in subquery is contained in list of literal prefixes, but is not used as one.

To fix problem lookahead StringTokenizer is used, similar to one in main (7.0.0) branch.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@mbladel
Copy link
Member

mbladel commented Feb 5, 2025

@cigaly thanks for taking a shot at this! I left a comment on your Jira to on making this change more consistent with what was done in main (see #8892).

@cigaly
Copy link
Contributor Author

cigaly commented Feb 5, 2025

You are right. I will create new PR with backported #8892 and close this one.

@cigaly cigaly closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants