HHH-18901 #9636
Open
HHH-18901 #9636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ The pull request title should contain at least 2 words to describe the change properly › This message was automatically generated. |
Sanne
force-pushed
the
HHH-18901-66-cleaned
branch
from
d4e96fc to
43ef237
Compare
beikov
reviewed
Jan 17, 2025
...rnate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java
Show resolved
Hide resolved
.../main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/OverridingClassFileLocator.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/SafeCacheProvider.java
Outdated
Show resolved
Hide resolved
yrodiere
approved these changes
Jan 17, 2025
...rnate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java
Outdated
Show resolved
Hide resolved
...nate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/ModelTypePool.java
Show resolved
Hide resolved
Comment on lines
+102
to
+103
| resolutions.remove( className ); | ||
| poolCache.remove( className ); |
There was a problem hiding this comment.
Maybe do this in deregisterClassNameAndBytes as well? Just in case...
There was a problem hiding this comment.
just to highlight, I've ignored this comment as I'm not very comfortable with the "just in case" ..it's indeed tempting, but it's beind de-registered in a finally block already so I wonder if it's making things a bit confusing for "future us".
Feel free to add it later if you feel strongly about it.
hibernate-core/src/main/java/org/hibernate/cfg/BytecodeSettings.java
Outdated
Show resolved
Hide resolved
...ate-core/src/main/java/org/hibernate/jpa/internal/enhance/EnhancingClassTransformerImpl.java
Outdated
Show resolved
Hide resolved
...ate-core/src/main/java/org/hibernate/jpa/internal/enhance/EnhancingClassTransformerImpl.java
Outdated
Show resolved
Hide resolved
…rrent enhancement In particular, made it defensive against concurrent enhancement of the same resource, or of resources that might trigger loading symbols which another thread is re-processing.
Sanne
force-pushed
the
HHH-18901-66-cleaned
branch
from
43ef237 to
7158074
Compare
|
Revised and ready |
scottmarlow
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft solution for https://hibernate.atlassian.net/browse/HHH-18901
We don't have a good test for this, and I didn't yet link the commits to appropriate Jiras... but I'd consider it now stable enough for others to have a look.
Specifically targeting branch 6.6 for now as that's where we can reproduce it: I'll "forward port" this if you all like it.
Thanks!