HHH-18556 Expressions.nullExpresion() in querydsl result in NPE in SqmExpressible #8936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Mar 27, 2025
| @@ -906,7 +907,7 @@ public CommonQueryContract setParameter(int position, Object value) { | |||
| final QueryParameter<Object> param = binding.getQueryParameter(); | |||
| if ( param.allowsMultiValuedBinding() ) { | |||
| final BindableType<?> hibernateType = param.getHibernateType(); | |||
| if ( hibernateType == null || isInstance( hibernateType, value ) ) { | |||
| if ( hibernateType == null || hibernateType instanceof NullSqmExpressible || isInstance( hibernateType, value ) ) { | |||
There was a problem hiding this comment.
@dreab8 Why did you make this change for positional parameters, but not for named parameters?
There was a problem hiding this comment.
Hi @gavinking,
a big oversight :( I'm going to open a Jira and fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18556
#8929 Backport
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.