Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_v1 #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test_v1 #7

wants to merge 1 commit into from

Conversation

ShreshShaurya
Copy link
Contributor

I have created pytest for discrete and load_data.

gaetanbrison
gaetanbrison reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@gaetanbrison gaetanbrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shre,

Great work !!
can you please update the following comments :)

All the best

DensLowRank/dataset/load_data.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove load data path
and put path as input of function load data

tests/tests_iris/test_load_data.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change order of import (ex: os)

tests/tests_model/tests_continuous/test_low_rank.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to delete

tests/tests_model/tests_discrete/test_discrete.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the empty raise seems a bit off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanbrison gaetanbrison gaetanbrison left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShreshShaurya @gaetanbrison