Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract hmr chunk from chunk.modules #6

Open
wants to merge 11 commits into
base: feat-rolldown-dev
Choose a base branch
from
+451 −274
Open

refactor: extract hmr chunk from chunk.modules #6

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b818ddd
chore(deps): use mini app format
hi-ogawa Nov 30, 2024
9db78bc
chore: use simple app format
hi-ogawa Nov 30, 2024
fc49b91
test: fix test
hi-ogawa Nov 30, 2024
a5a4ab3
refactor: extract hmr chunk from bundle
hi-ogawa Nov 30, 2024
3ef80be
chore: rename to "experimental-app"
hi-ogawa Nov 30, 2024
8f0a9dc
chore(deps): use nightly
hi-ogawa Dec 2, 2024
ea2a629
chore(deps): use rolldown 0.15.0
hi-ogawa Dec 2, 2024
1df4042
fix: fix inline css hmr
hi-ogawa Dec 3, 2024
7290436
chore: cleanup
hi-ogawa Dec 3, 2024
8773916
wip: asset url hmr
hi-ogawa Dec 3, 2024
d6c02ae
test: skip for now
hi-ogawa Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
chore(deps): use rolldown 0.15.0
@hi-ogawa
hi-ogawa committed Dec 3, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit ea2a62959f639dbaa868279022f9dd75e65f1e04
2 changes: 1 addition & 1 deletion packages/vite/package.json
View file
Original file line number Diff line number Diff line change
@@ -88,7 +88,7 @@
"esbuild": "^0.24.0",
"postcss": "^8.4.49",
"react-refresh": "^0.14.2",
"rolldown": "0.14.0-snapshot-12d7e71-20241201004055",
"rolldown": "0.15.0",
"rollup": "^4.23.0"
},
"optionalDependencies": {
106 changes: 53 additions & 53 deletions pnpm-lock.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Unchanged files with check annotations Beta

View file
packages/vite/src/node/__tests__/build.spec.ts
expect(
chunk.code,
`the ${chunk.fileName} chunk has the same hash but different contents between builds`,
).toEqual(chunk2.code)

Check failure on line 748 in packages/vite/src/node/__tests__/build.spec.ts

GitHub Actions / Build&Test: node-18, ubuntu-latest

packages/vite/src/node/__tests__/build.spec.ts > build > file hash should change when pure css chunk changes 

AssertionError: the assets/index-DhXWseme.js chunk has the same hash but different contents between builds: expected 'const __vite__mapDeps=(i,m=__vite__ma…' to deeply equal 'const __vite__mapDeps=(i,m=__vite__ma…'

- Expected
+ Received

- const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-dekYVk4v.js","assets/_foo-3otn9bEy.css","assets/_baz-8tIYWJw7.css","assets/_bar-CYtjVUa5.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
+ const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-DAiqd_VM.js","assets/_foo-3otn9bEy.css","assets/_baz-8tIYWJw7.css","assets/_bar-DeM4UPAy.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
- (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.as="script"),i.crossOrigin="",i.href=o,m&&i.setAttribute("nonce",m),document.head.appendChild(i),u)return new Promise((a,d)=>{i.addEventListener("load",a),i.addEventListener("error",()=>d(new Error(`Unable to preload CSS for ${o}`)))})}))}function t(n){const r=new Event("vite:preloadError",{cancelable:!0});if(r.payload=n,window.dispatchEvent(r),!r.defaultPrevented)throw n}return e.then(n=>{for(const r of n||[])r.status==="rejected"&&t(r.reason);return s().catch(t)})};window.addEventListener("click",()=>{p(()=>import("./_foo-dekYVk4v.js"),__vite__mapDeps([0,1,2]))});window.addEventListener("click",()=>{p(()=>import("./_bar-CYtjVUa5.js"),__vite__mapDeps([3,4,2]))});
+ (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.as="script"),i.crossOrigin="",i.href=o,m&&i.setAttribute("

Check failure on line 748 in packages/vite/src/node/__tests__/build.spec.ts

GitHub Actions / Build&Test: node-22, ubuntu-latest

packages/vite/src/node/__tests__/build.spec.ts > build > file hash should change when pure css chunk changes 

AssertionError: the assets/index-DhXWseme.js chunk has the same hash but different contents between builds: expected 'const __vite__mapDeps=(i,m=__vite__ma…' to deeply equal 'const __vite__mapDeps=(i,m=__vite__ma…'

- Expected
+ Received

- const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-DE7z1b4O.js","assets/_foo-3otn9bEy.css","assets/_baz-XbyN5Pu5.css","assets/_baz-8tIYWJw7.css","assets/_bar-B3ISlUG8.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
+ const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-DAiqd_VM.js","assets/_foo-3otn9bEy.css","assets/_baz-XbyN5Pu5.css","assets/_baz-8tIYWJw7.css","assets/_bar-DeM4UPAy.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
- (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.as="script"),i.crossOrigin="",i.href=o,m&&i.setAttribute("nonce",m),document.head.appendChild(i),u)return new Promise((a,d)=>{i.addEventListener("load",a),i.addEventListener("error",()=>d(new Error(`Unable to preload CSS for ${o}`)))})}))}function t(n){const r=new Event("vite:preloadError",{cancelable:!0});if(r.payload=n,window.dispatchEvent(r),!r.defaultPrevented)throw n}return e.then(n=>{for(const r of n||[])r.status==="rejected"&&t(r.reason);return s().catch(t)})};window.addEventListener("click",()=>{p(()=>import("./_foo-DE7z1b4O.js"),__vite__mapDeps([0,1,2,3]))});window.addEventListener("click",()=>{p(()=>import("./_bar-B3ISlUG8.js"),__vite__mapDeps([4,5,2,3]))});
+ (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.

Check failure on line 748 in packages/vite/src/node/__tests__/build.spec.ts

GitHub Actions / Build&Test: node-22, windows-latest

packages/vite/src/node/__tests__/build.spec.ts > build > file hash should change when pure css chunk changes 

AssertionError: the assets/index-DhXWseme.js chunk has the same hash but different contents between builds: expected 'const __vite__mapDeps=(i,m=__vite__ma…' to deeply equal 'const __vite__mapDeps=(i,m=__vite__ma…'

- Expected
+ Received

- const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-DAiqd_VM.js","assets/_foo-3otn9bEy.css","assets/_baz-8tIYWJw7.css","assets/_baz-XbyN5Pu5.css","assets/_bar-DeM4UPAy.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
+ const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=["assets/_foo-DpIGDHs8.js","assets/_foo-3otn9bEy.css","assets/_baz-8tIYWJw7.css","assets/_baz-XbyN5Pu5.css","assets/_bar-C-9OPOWL.js","assets/_bar-1BxK95df.css"])))=>i.map(i=>d[i]);
- (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.as="script"),i.crossOrigin="",i.href=o,m&&i.setAttribute("nonce",m),document.head.appendChild(i),u)return new Promise((a,d)=>{i.addEventListener("load",a),i.addEventListener("error",()=>d(new Error(`Unable to preload CSS for ${o}`)))})}))}function t(n){const r=new Event("vite:preloadError",{cancelable:!0});if(r.payload=n,window.dispatchEvent(r),!r.defaultPrevented)throw n}return e.then(n=>{for(const r of n||[])r.status==="rejected"&&t(r.reason);return s().catch(t)})};window.addEventListener("click",()=>{p(()=>import("./_foo-DAiqd_VM.js"),__vite__mapDeps([0,1,2,3]))});window.addEventListener("click",()=>{p(()=>import("./_bar-DeM4UPAy.js"),__vite__mapDeps([4,5,2,3]))});
+ (function(){const s=document.createElement("link").relList;if(s&&s.supports&&s.supports("modulepreload"))return;for(const e of document.querySelectorAll('link[rel="modulepreload"]'))l(e);new MutationObserver(e=>{for(const t of e)if(t.type==="childList")for(const n of t.addedNodes)n.tagName==="LINK"&&n.rel==="modulepreload"&&l(n)}).observe(document,{childList:!0,subtree:!0});function c(e){const t={};return e.integrity&&(t.integrity=e.integrity),e.referrerPolicy&&(t.referrerPolicy=e.referrerPolicy),e.crossOrigin==="use-credentials"?t.credentials="include":e.crossOrigin==="anonymous"?t.credentials="omit":t.credentials="same-origin",t}function l(e){if(e.ep)return;e.ep=!0;const t=c(e);fetch(e.href,t)}})();const v="modulepreload",E=function(f){return"/"+f},h={},p=function(s,c,l){let e=Promise.resolve();if(c&&c.length>0){const n=document.getElementsByTagName("link"),r=document.querySelector("meta[property=csp-nonce]"),m=(r==null?void 0:r.nonce)||(r==null?void 0:r.getAttribute("nonce"));e=Promise.allSettled(c.map(o=>{if(o=E(o,l),o in h)return;h[o]=!0;const u=o.endsWith(".css"),y=u?'[rel="stylesheet"]':"";if(!!l)for(let a=n.length-1;a>=0;a--){const d=n[a];if(d.href===o&&(!u||d.rel==="stylesheet"))return}else if(document.querySelector(`link[href="${o}"]${y}`))return;const i=document.createElement("link");if(i.rel=u?"stylesheet":v,u||(i.
}
}
}