Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): render module factory #4

Open
wants to merge 9 commits into
base: feat-hmr-chunk
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Dec 8, 2024

todo

  • wrap module factory
  • rewrite all globals with __runtime.xxx
    • helpers __export, __toCommonJs, etc..
    • cjs exports, modules, require, etc...
  • test on vite poc refactor: use module factory vite#11

Copy link

github-actions bot commented Dec 8, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     75.0±1.76ms        ? ?/sec    1.00     75.0±3.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     96.0±1.46ms        ? ?/sec    1.03     99.2±3.24ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    112.3±2.10ms        ? ?/sec    1.01    113.0±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.0±1.33ms        ? ?/sec    1.04     84.5±2.02ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    125.8±1.87ms        ? ?/sec    1.00    125.5±1.95ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    214.2±3.41ms        ? ?/sec    1.00    213.5±3.56ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    248.7±2.20ms        ? ?/sec    1.03    255.2±3.82ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    141.0±2.87ms        ? ?/sec    1.01    142.8±1.71ms        ? ?/sec
bundle/bundle@threejs                                               1.01     37.4±1.75ms        ? ?/sec    1.00     37.1±1.19ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     89.8±1.53ms        ? ?/sec    1.02     92.0±3.26ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.03    107.3±3.35ms        ? ?/sec    1.00    104.2±1.42ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     48.7±1.22ms        ? ?/sec    1.00     48.0±0.92ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    407.4±5.05ms        ? ?/sec    1.00    406.8±6.29ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.02   1102.9±6.52ms        ? ?/sec    1.00   1084.1±9.39ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1312.4±11.76ms        ? ?/sec    1.00  1298.1±21.00ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    483.9±7.14ms        ? ?/sec    1.00    483.9±4.94ms        ? ?/sec
remapping/remapping                                                 1.00     29.2±0.21ms        ? ?/sec    1.01     29.4±0.43ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     76.2±1.03ms        ? ?/sec    1.01     77.0±0.38ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     98.2±1.49ms        ? ?/sec    1.07    104.8±1.30ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.3±0.92ms        ? ?/sec    1.08     30.5±1.30ms        ? ?/sec
scan/scan@threejs10x                                                1.00    291.5±3.39ms        ? ?/sec    1.03    300.6±2.51ms        ? ?/sec

@hi-ogawa hi-ogawa marked this pull request as ready for review December 8, 2024 08:13
@hi-ogawa hi-ogawa mentioned this pull request Dec 8, 2024
7 tasks
Copy link

github-actions bot commented Jan 8, 2025

This PR is considered stale and will be convert to draft soon. Please undraft it if you think it's ready to be reviewed.

@github-actions github-actions bot added the stale label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant