Send events only for selected day & refactor KalendarEvent #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Events are now sent only for the specific day that is clicked. - Refactored `KalendarEvent` into an interface for better flexibility:
- Events are now sent only for the specific day that is clicked. - Refactored `KalendarEvent` into an interface for better flexibility:
…shu/Kalendar into fix/KalendarEventAndClick
| import kotlinx.datetime.LocalDate | ||
|
|
||
| fun LocalDate.onDayClick( | ||
| events: List<KalendarEvent>, | ||
| events: List<KalenderEvent>, |
There was a problem hiding this comment.
from performance perspective, can you migrate all list usages to ImmutableList?
There was a problem hiding this comment.
I can, but that all plan is for later implementation!
| /** | ||
| * Represents an event in the calendar. | ||
| */ | ||
| interface KalenderEvent { |
| @@ -58,7 +58,7 @@ fun KalendarDay( | |||
| selectedDate: LocalDate = date, | |||
| events: KalendarEvents = KalendarEvents(), | |||
| dayKonfig: KalendarDayKonfig = KalendarDayKonfig.default(), | |||
| onDayClick: (LocalDate, List<KalendarEvent>) -> Unit = { _, _ -> }, | |||
| onDayClick: (LocalDate, List<KalenderEvent>) -> Unit = { _, _ -> }, | |||
There was a problem hiding this comment.
I think you should extend compose compiler parameters and declare LocalDate as a stable type. This can help in perf
There was a problem hiding this comment.
Yea, can be done. Later in plan
|
Added this @PatilShreyas thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KalendarEventinto an interface for better flexibility:Details:
#184