Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more env vars & unify show-dms #215

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

volker-fr
Copy link
Contributor

@volker-fr volker-fr commented Jan 19, 2025

  1. Add a few more environment variables where they have been missing
  2. All new environment variables added in the last months start now with SEV_
  3. unify the cli's and webservers command line flag to show/hide DM's.
  4. add a new flag to not add the "Thread message:" to a message. Default is to keep "Thread message:" to be backward compatible. The use case is not really clear at this point since threads can now be identified differently. In the past the template did a check, but this has been improved in Improve thread representation #204
  5. Update --help documentation to contain the environment variable & default value.
  6. Remove the click helper utils file after replacing it with the click internal env var & default value option.

(2) and (3) are not backward compatible changes. Since these flags are relatively new, having a breaking change here should be fine. Click will also warn about a not supported flag.

@volker-fr volker-fr force-pushed the envvars branch 4 times, most recently from 5e4e81c to 1d92da2 Compare January 20, 2025 22:04
@hfaran hfaran merged commit a3dd2e3 into hfaran:master Jan 21, 2025
2 checks passed
@volker-fr volker-fr deleted the envvars branch January 23, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants