Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's annoying when going through old code with lots of unquoted arguments, and just add quotes to them all, and then being met with "InvalidArgumentException: int"
This has happened to me several times in the past, and it very nearly happened again here with
$ssl_enabled
: https://github.com/hestiacp/hestiacp/pull/4569/files#diff-55ab675d04a6f347147d37a4232b891f10f2c91b05f4126f16d93e75139b1c0cR87It's better to just support it.
Btw if we don't care about PHP7.4 compatibility, it would be better to use