feat: release binaries #105
Conversation
marco-ippolito
force-pushed
the
pack-some-bins
branch
from
a5f13f9 to
082da69
Compare
marco-ippolito
force-pushed
the
pack-some-bins
branch
11 times, most recently
from
9878c46 to
52a82e6
Compare
|
I think the command The documentation isn't super clear on how the |
marco-ippolito
force-pushed
the
pack-some-bins
branch
12 times, most recently
from
326bb64 to
70b220c
Compare
marco-ippolito
force-pushed
the
pack-some-bins
branch
from
70b220c to
344ba07
Compare
| @@ -17,7 +16,7 @@ $ npm install -g @herodevs/cli | |||
| $ hd COMMAND | |||
| running command... | |||
| $ hd (--version) | |||
| @herodevs/cli/2.0.0 darwin-arm64 node-v22.14.0 | |||
| @herodevs/cli/2.0.0 darwin-arm64 node-v22.13.0 | |||
There was a problem hiding this comment.
Nit: should this be @herodevs/cli/1.0.0-beta This comment also applies to all other instances of @herodevs/cli/2.0.0 (and "version": "2.0.0") in this PR
| ], | ||
| "license": "MIT", | ||
| "optionalDependencies": { | ||
| "@herodevs/cli-darwin-arm64": "^2.0.0", |
There was a problem hiding this comment.
Nit: should this be @herodevs/cli/1.0.0-beta (for each optional dependency)
| "version": "2.0.0", | ||
| "name": "@herodevs/monorepo", | ||
| "private": true, | ||
| "version": "0.0.0", |
There was a problem hiding this comment.
Nit: should this be @herodevs/cli/1.0.0-beta
| @@ -0,0 +1 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Is this the script that will eventually become the biome-like glue code?
https://github.com/biomejs/biome/blob/main/packages/%40biomejs/biome/bin/biome
| runs-on: ${{ matrix.os }} | ||
| needs: check | ||
| env: | ||
| version: ${{ needs.check.outputs.version }} |
There was a problem hiding this comment.
So with this setup, after the pull_request trigger is removed it looks like this would be how we trigger a release:
- work on feature branch
- push commit to feature branch
chore(release): v1.0.0-beta - create PR into main
- review PR, merge into main (no deployment yet)
- manually trigger workflow_dispatch from GitHub
- the release workflow is invoked, sees a version diff in the commit, and triggers a deployment
| push: | ||
| branches: | ||
| - main | ||
| pull_request: # remove me when ready | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Nit: instead of workflow_dispatch and EndBug/version-check, I'd recommend the release be triggered on pushed git tags, similar to our other product release workflows:
on:
push:
tags:
- "v*.*.*"
The workflow_dispatch could then be reserved for dry runs only.
No description provided.