-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release binaries #105
base: dev
Are you sure you want to change the base?
Conversation
a5f13f9
to
082da69
Compare
9878c46
to
52a82e6
Compare
I think the command The documentation isn't super clear on how the |
326bb64
to
70b220c
Compare
70b220c
to
344ba07
Compare
@@ -17,7 +16,7 @@ $ npm install -g @herodevs/cli | |||
$ hd COMMAND | |||
running command... | |||
$ hd (--version) | |||
@herodevs/cli/2.0.0 darwin-arm64 node-v22.14.0 | |||
@herodevs/cli/2.0.0 darwin-arm64 node-v22.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should this be @herodevs/cli/1.0.0-beta
This comment also applies to all other instances of @herodevs/cli/2.0.0
(and "version": "2.0.0") in this PR
], | ||
"license": "MIT", | ||
"optionalDependencies": { | ||
"@herodevs/cli-darwin-arm64": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should this be @herodevs/cli/1.0.0-beta
(for each optional dependency)
"version": "2.0.0", | ||
"name": "@herodevs/monorepo", | ||
"private": true, | ||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should this be @herodevs/cli/1.0.0-beta
@@ -0,0 +1 @@ | |||
#!/usr/bin/env node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the script that will eventually become the biome-like glue code?
https://github.com/biomejs/biome/blob/main/packages/%40biomejs/biome/bin/biome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
runs-on: ${{ matrix.os }} | ||
needs: check | ||
env: | ||
version: ${{ needs.check.outputs.version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this setup, after the pull_request
trigger is removed it looks like this would be how we trigger a release:
- work on feature branch
- push commit to feature branch
chore(release): v1.0.0-beta
- create PR into main
- review PR, merge into main (no deployment yet)
- manually trigger workflow_dispatch from GitHub
- the release workflow is invoked, sees a version diff in the commit, and triggers a deployment
push: | ||
branches: | ||
- main | ||
pull_request: # remove me when ready | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: instead of workflow_dispatch and EndBug/version-check
, I'd recommend the release be triggered on pushed git tags, similar to our other product release workflows:
on:
push:
tags:
- "v*.*.*"
The workflow_dispatch
could then be reserved for dry runs only.
No description provided.