Fixed a Helix crash on launch when the install directory cannot be canonicalized (the ol' .unwrap_or)
#12879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonicalized (the ol' `.unwrap_or`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admittedly have a weird situation in that I installed Helix on a RAM disk (RAM being treated as a mounted filesystem)
Regardless, Helix crashes immediately on startup because of this canonicalization of the path which fails in my situation.
Let me know if I should write this differently, I've never contributed before so don't know what's up. There are several other file system related
.unwrap()s in this same function which returns "A list of runtime directories from highest to lowest priority" that might also want to be examined or some error handling added (even just something like a.expect()).At least partially fixes #12880