add final flag to sync blocks message #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecaswell
added a commit
to helium/blockchain-core
that referenced
this pull request
Mar 15, 2022
joecaswell
added a commit
to helium/blockchain-core
that referenced
this pull request
Mar 15, 2022
deduplicate block send code update rebar.lock depends on helium/proto#125
joecaswell
added a commit
to helium/blockchain-core
that referenced
this pull request
Mar 15, 2022
deduplicate block send code update rebar.lock depends on helium/proto#125
|
Huh, could you explain how this is useful? |
|
This is part of the fix for helium/blockchain-core#1273. If the sender is expected to notify the recipient when the final block has been sent, the recipient can gossip only the last block. When a node is catching up, such as after loading a snapshot, it is probable that most of its peers already have the intermediate blocks, so gossiping a block from every batch is essentially noise and wasted bandwidth. |
madninja
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to blockchain_sync record to indicate final batch of blocks